Skip to content

Merge latest changes from bugfix#25

Closed
thinkyhead wants to merge 0 commit intoteemuatlut:bf2_new_libraryfrom
thinkyhead:bf2_new_tmc_library_redux
Closed

Merge latest changes from bugfix#25
thinkyhead wants to merge 0 commit intoteemuatlut:bf2_new_libraryfrom
thinkyhead:bf2_new_tmc_library_redux

Conversation

@thinkyhead
Copy link

Merged, and submitting as a PR for convenience.

@thinkyhead
Copy link
Author

thinkyhead commented Sep 30, 2018

The reason for the Travis CI errors is that the TMC2130 tests are actually being run now, thanks to improvements to the set_opt commands (71d06ef). As a result some bugs in tmc_util.cpp are being exposed.

Marlin/src/feature/tmc_util.cpp:47:8: error: 'template<char AXIS_LETTER, char DRIVER_ID> class TMCStorage' used without template parameters
bool TMCStorage::report_tmc_status = false;
^~~~~~~~~~
Marlin/src/feature/tmc_util.cpp: In function 'uint8_t get_status_response(TMC2130Stepper&)':
Marlin/src/feature/tmc_util.cpp:57:72: error: 'uint8_t TMC2130Stepper::status_response' is protected within this context
static uint8_t get_status_response(TMC2130Stepper &st) { return st.status_response & 0xF; }
^~~~~~~~~~~~~~~
In file included from Marlin/src/feature/tmc_util.h:28:0,
from Marlin/src/feature/tmc_util.cpp:27:
.piolibdeps/TMCStepper_ID5513/src/TMCStepper.h:334:11: note: declared protected here
uint8_t status_response;
^~~~~~~~~~~~~~~
Marlin/src/feature/tmc_util.cpp: In function 'TMC_driver_data get_driver_data(TMC2130Stepper&)':
Marlin/src/feature/tmc_util.cpp:69:27: error: 'uint8_t TMC2130Stepper::status_response' is protected within this context
data.is_error = (st.status_response & DRIVER_ERROR_bm) >> DRIVER_ERROR_bp;
^~~~~~~~~~~~~~~
In file included from Marlin/src/feature/tmc_util.h:28:0,
from Marlin/src/feature/tmc_util.cpp:27:
.piolibdeps/TMCStepper_ID5513/src/TMCStepper.h:334:11: note: declared protected here
uint8_t status_response;
^~~~~~~~~~~~~~~
Marlin/src/feature/tmc_util.cpp: In function 'void monitor_tmc_driver()':
Marlin/src/feature/tmc_util.cpp:208:11: error: 'template<char AXIS_LETTER, char DRIVER_ID> class TMCStorage' used without template parameters
if (TMCStorage::report_tmc_status) SERIAL_EOL();
^~~~~~~~~~
Marlin/src/feature/tmc_util.cpp: In function 'void tmc_set_report_status(bool)':
Marlin/src/feature/tmc_util.cpp:503:10: error: 'template<char AXIS_LETTER, char DRIVER_ID> class TMCStorage' used without template parameters
if ((TMCStorage::report_tmc_status = status))
^~~~~~~~~~
*** [.pioenvs/LPC1768/src/src/feature/tmc_util.o] Error 1

@teemuatlut teemuatlut force-pushed the bf2_new_library branch 3 times, most recently from a44f6f7 to 374e12d Compare September 30, 2018 19:12
@thinkyhead thinkyhead closed this Oct 1, 2018
@thinkyhead thinkyhead deleted the bf2_new_tmc_library_redux branch October 1, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments