-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 quote sqlv8 values #1479
Merged
Merged
🐛 quote sqlv8 values #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensby
force-pushed
the
pulls/sqlv8-escape
branch
2 times, most recently
from
March 20, 2023 10:03
a14f06f
to
75bd474
Compare
abhku
previously approved these changes
Mar 20, 2023
dhensby
force-pushed
the
pulls/sqlv8-escape
branch
from
March 20, 2023 10:10
75bd474
to
4804420
Compare
dhensby
force-pushed
the
pulls/sqlv8-escape
branch
from
August 7, 2023 18:43
4804420
to
efe1c22
Compare
dhensby
force-pushed
the
pulls/sqlv8-escape
branch
from
August 7, 2023 18:58
efe1c22
to
75b74f6
Compare
🎉 This PR is included in version 9.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 8, 2023
This was referenced Aug 8, 2023
This was referenced Aug 9, 2023
1 task
1 task
This was referenced Sep 9, 2024
Closed
Closed
Closed
This was referenced Sep 16, 2024
Closed
This was referenced Oct 1, 2024
This was referenced Oct 9, 2024
Closed
Closed
This was referenced Oct 17, 2024
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does:
This quotes generic arguments for the constructed connection string that is passed to msnodesqlv8; previous special chars in fields like password could end up breaking the connection string.
Related issues:
Fixes #1476
Pre/Post merge checklist: