Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen is not doing well 100% #40

Open
Harrenkyym opened this issue Jan 2, 2025 · 9 comments
Open

Fullscreen is not doing well 100% #40

Harrenkyym opened this issue Jan 2, 2025 · 9 comments

Comments

@Harrenkyym
Copy link

Hey, I'm using the fullscreen option and I have a problem, the movie featured is not displaying from the top of the screen. So I have a black bar for the top menu. I have to scroll a little bit to have everything on the screen:

Screenshot 2025-01-02 at 15-28-20 Jellyfin
Screenshot 2025-01-02 at 15-27-28 Jellyfin

And I don't know if you notice a little horizontal line (just 1px) at the bottom that I don't know where it comes from (It's not from the image itself, it happens always, not just with the Joker one)... It's not a concern, but it's a weird thing.

And one last thing, the titles of the movies to keep watching are cut in half. :/

Thank you!

@Harrenkyym
Copy link
Author

Harrenkyym commented Jan 2, 2025

I just connected my laptop to my external monitor msi g24c4 e2 and it's even more screwed...

Screenshot 2025-01-02 at 19-38-57 Jellyfin

Check the keep watching section...

imagen

@tedhinklater
Copy link
Owner

@tedhinklater
Copy link
Owner

should be fixed in the latest

@Harrenkyym
Copy link
Author

Hey, sorry, I've been some days off.

I know you've closed it, but I don't think you should yet. I've tried your fix and it is much better than before.

It is possible to place the image just at the top? without the black bar. I know it's an iframe placed after it, but maybe with the css it can be moved or something, I don't know...

I'm gonna refer to this topic, where I said a few things: #35

399722396-6d534cea-4bd8-4005-b411-cd14650fd9c4

That's how I see fullscreen on my phone (and the same for my tablet).

@tedhinklater tedhinklater reopened this Jan 6, 2025
@Harrenkyym
Copy link
Author

This is the phone rotated, notice that genres are over the logo. :/
Screenshot_2025-01-07-00-51-55-89_4b95a63cd60fd3e0f30739d89812bf6c

This is the tablet:
Screenshot_20250107-005343_Jellyfin
Screenshot_20250107-005348_Jellyfin
Screenshot_20250107-005330_Jellyfin

When rotated you just have the storyline, no duration, year or rating. :/

You can use me as your tester. I can use 4 different screens (laptop, external monitor, smartphone and tablet). I could even try on my smart tv, but for the moment I'm sadly using the tv app...

@Harrenkyym
Copy link
Author

I'm gonna continue here, because it's about fullscreen.

For ages I've been using jellyfin in Firefox (when I use my laptop) with a 80% of its size, just because I read somewhere it was more how it should be displayed rather than how it looks when it is at its normal size, without resizing, and it is true. Everything looks much better at 80%, starting with the top bar.

That said, with your last version, it looks "ok" at 100% but horrible at 80%, which wasn't happening before, before at 80% it was as good as 100%.

Now it looks like this:

imagen

NOTE: Wow, I just discovered it just happens on my 23" msi monitor, on my laptop (15,6) it is displaying correctly, That image is from my monitor. :/

What about not having the top bar, is that really impossible? Or well, not not having it, but making the top of the image the background of the top bar. Like, I don't know, setting the background transparent and push up the iframe via css.

And on Android:

  • the big blank space between Spotlight and the rest of the content still there (both browser and app)
  • One more behaviour that I would expect different: touching Spotlight for a few seconds shouldn't "select" it, like you know, the "blue highlight", I don't know how to explain it really. (That's happening in the app, at least not in firefox browser for Android). It's something that happens frequently because it happens when you drag. Ah, the blue selection of Spotlight it's also happening when I press "next".

@tedhinklater
Copy link
Owner

Ok I've tried a different approach to the scaling, hopefully it works better

fullscreen spotlight
fullscreen home-html

@tedhinklater
Copy link
Owner

the highlight bug has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants