Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few enhancement suggestions #35

Open
somechazzy opened this issue Dec 23, 2024 · 12 comments
Open

A few enhancement suggestions #35

somechazzy opened this issue Dec 23, 2024 · 12 comments
Labels
enhancement New feature or request

Comments

@somechazzy
Copy link
Contributor

  1. "Trailer" and "Play" buttons aren't relative to each other for centering. In my case I have many titles without a trailer, so the "Play" button remains aligned to the middle-right of the spotlight even if the "Trailer" button is missing.
  2. A smooth transition between titles. Currently the spotlight just abruptly stops its animation and changes to previewing the new title without a fade-out for the previous one, nor a fade-in for the current.
  3. Overlay items (logo, genres, buttons etc..) take a little too long to display. While this is entirely subjective I still thought I should mention it.

Many thanks for your work.

@Harrenkyym
Copy link

More suggestions:

  • To be able to use the ID of a collection to display its entire content.
  • Following this thread, I've would suggest the transition to be kind of a "slideshow" where you can even click AND drag, that's way better for phones or tablets. (like here https://www.codingnepalweb.com/draggable-image-slider-html-css-javascript/)
  • It is not accepting series right now. I've tried and it's like I haven't set any ID on the list. It would be cool if we can have series too.
  • It would be great if we could add some kind of custom message (or even image). For example "It's Christmas time!" or "Oscar season!" in a corner or I don't know, but something that the users (for me it's my family) know why the movie is featured. When I say "or even image" I'm thinking about something like that, where if you have skills, you can custom the image like you want:
    etiqueta-esquina-etiqueta-esquina-ilustracion-3d_118019-8762
  • I think the rating tag is oversized... I don't know, but at least in Spain we are not that picky with that. (And in my particular case, in my family there are only adults, so I don't care a second about it)
  • That's how I see the fullscreen spotlight in my phone... And if I rotate the screen (which I never do it), the space between the image and my collections still there.
    thumbnail_1000100545

I think that's all.

@tedhinklater
Copy link
Owner

the trailer/play buttons have been justified and the opacity timing adjusted

@tedhinklater tedhinklater added the enhancement New feature or request label Jan 5, 2025
@tedhinklater
Copy link
Owner

  • It is not accepting series right now. I've tried and it's like I haven't set any ID on the list. It would be cool if we can have series too.

It should definitely accept series/shows. Fullscreen has been redone hopefully it's a bit better

@Harrenkyym
Copy link

  • It is not accepting series right now. I've tried and it's like I haven't set any ID on the list. It would be cool if we can have series too.

It should definitely accept series/shows. Fullscreen has been redone hopefully it's a bit better

Yep, I noticed it does! The thing is I discovered it doesn't accept content without logo (movie or series) and the series I wanted to show didn't have a logo. I set a good one and the series was displayed immediately.
The bad thing is that it is in english. It says "1 Season" instead of "1 temporada", it should be in spanish (in my case, obviously). Is there something that must be translated somewhere?

And I've noticed too something weird. You can't "go back" from the first content displayed. You can go forward and see again the first content, but if you go back you'll always get to the first element displayed (for the first time, when everything loads) then you can't go back anymore... I think it should be an endless carousel. :D

@tedhinklater
Copy link
Owner

collections/albums work now, swiping too on mobile

@tedhinklater
Copy link
Owner

I'm trying to get language localization working, in the meantime you can edit spotlight.html and replace Season$ with Temporada$

@Harrenkyym
Copy link

Harrenkyym commented Jan 14, 2025

Ok, I replaced the Temporada word, but now I realized that genres are also in english. I hope you can make the different languages work!

A few things:
I quote myself "And I've noticed too something weird. You can't "go back" from the first content displayed. You can go forward and see again the first content, but if you go back you'll always get to the first element displayed (for the first time, when everything loads) then you can't go back anymore... I think it should be an endless carousel. :D"

Now, when you go back, at some point you go to a null item (if you go back from the start, it happens exactly at that moment) and the complete feature disapears... :/ It happens in Android and browser, I've tried both.

Another thing I've noticed is, in Android, when you touch the screen to scroll, if you touch the iframe, the scroll doesn't work, you have to touch somewhere else to go down. And with fullscreen that only let you touch the top bar (which you know I'd love to do not have it so for real fullscreen means fullscreen).

I couldn't make the collection feature works. I've set some ID's from collections and movies/series and it's displaying just movies and series (not from the collections).

And could you make a version for "not important age rating". I know to have them is important for a lot of people, for parents, etc. but I'm pretty sure that I'm not the only one who doesn't really care about it and it would be nice to hide it a little bit. :D

@tedhinklater
Copy link
Owner

The genres section just displays the content's genres metadata, so if it's written in English in the metadata the bar will display that.

I can't recreate the null item bug you described, I'll keep looking.

I see what you're saying about the scrolling, I'll fix that now.

Make sure your collection has a Backdrop image and Logo image.

I've changed the Age Rating to be hidden after a second or so

genres

@tedhinklater
Copy link
Owner

mobile scrolling/swiping is fixed now

@Harrenkyym
Copy link

  • Yep, I just discovered that genres of series en tmdb are shit, less than in movies and not translated...

  • The null thing happens when the content on the list is not displaying (maybe because there is no logo), I discovered that it just happens with not displaying content, it makes Spotlight disappear at some point.

I don't see that age thing happening on fullscreen at least. Anyway, I think there should be an option to make it important or not, because I'm pretty sure there are a lot of people who needs it.

  • I promise I've used a collection with backdrop image and logo, where movies inside have backdrop image and logo... I can't see them.

@tedhinklater
Copy link
Owner

tedhinklater commented Jan 15, 2025

Just so we're on the same page: you downloaded the latest spotlight.html (fullscreen) and pasted the latest home-html.chunk.js (fullscreen) and have the fullscreen css? and your external monitor is 1080p 16:9 ? and emptied the cache?

@Harrenkyym
Copy link

Yes, but as I said, it only happens because I set my jellyfin site to display at the 80% of the normal size. But a few versions ago it was perfect with that 80%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants