Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static builder on travis #260

Merged
merged 5 commits into from
Nov 21, 2018
Merged

Conversation

malbarbo
Copy link
Contributor

Includes #259

@malbarbo
Copy link
Contributor Author

malbarbo commented Nov 15, 2018

The next step to fix #185 is to deploy the static build. But I don't known how to do it.

@pkgw
Copy link
Collaborator

pkgw commented Nov 16, 2018

Cool, thanks! Let's hold this until #259 converges.

@pkgw pkgw self-assigned this Nov 16, 2018
malbarbo and others added 5 commits November 17, 2018 11:51
- Rename the feature to "serialization"
- Expand the commentary in README.md a bit
- Add docstrings to the two `PersistentConfig::open()` methods
- Single-line style in the `extern crate` directives
When linking statically on musl targets, this function clashes with a symbol
in OpenSSL. So just rename it.
- Don't bother with the Docker shell scripts, which were one-liners
- docker/x86_musl => dist/docker/x86-alpine-linux-musl
- The rename of AES_cbc_encrypt is now permanently applied
- Run the test suite inside the static container
- Add copyright/license headers
- Move the pkg-config-rs patching script to the specific Docker directory
- Add Cargo.toml note about tracking the correct version of pkg-config.rs
@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@d645924). Click here to learn what that means.
The diff coverage is 45.34%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #260   +/-   ##
=========================================
  Coverage          ?   41.47%           
=========================================
  Files             ?      135           
  Lines             ?    61169           
  Branches          ?        0           
=========================================
  Hits              ?    25371           
  Misses            ?    35798           
  Partials          ?        0
Impacted Files Coverage Δ
src/lib.rs 0% <ø> (ø)
src/config.rs 25.73% <45.34%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d645924...4fcb5a3. Read the comment docs.

@pkgw
Copy link
Collaborator

pkgw commented Nov 20, 2018

I've pushed an update that rebases this on #261 and makes some tweaks that I think tighten things up a bit. @malbarbo let me know what you think about these changes?

@malbarbo
Copy link
Contributor Author

@pkgw It's look great to me! Thanks for working on this.

@pkgw pkgw merged commit 9495808 into tectonic-typesetting:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants