Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendored redux #40

Merged
merged 1 commit into from
Aug 9, 2017
Merged

Remove vendored redux #40

merged 1 commit into from
Aug 9, 2017

Conversation

jmckible
Copy link
Contributor

@jmckible jmckible commented Aug 7, 2017

As we embrace webpack for dependency management, we need to remove library loads from the pano js pipeline. Until CX is also migrated, you'll need to vendor a copy of redux and include it in your app/index.coffee.

Since this is a breaking change, my intention is to start a new v2.1.0 release of pano if this meets with your approval.

FYI @mmlindeboom
Need 👍 from @mkmiller / @bullrico

@jmckible jmckible self-assigned this Aug 7, 2017
@jmckible jmckible requested review from bullrico and mkmiller August 7, 2017 16:50
Copy link
Contributor

@mkmiller mkmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure makes sense.

I may have pano changes for i18n, so I'll have to decide whether v2.0.2 or v2.1

@jmckible
Copy link
Contributor Author

jmckible commented Aug 8, 2017

Do you foresee any i18n changes being breaking for Engage? The general road map I have in my mind is:

2.0.x - Bug fixes for the current UI
2.1.0 - Remove third party libraries from Pano. Engage will load them via webpack, CX via vendor/
3.0.0 - Move all javascript from pano into another repo (pano-js is what I've been calling it). That repo would be packaged and loadable via webpack. The individual apps would need to load pano-js, until such time as rails/webpacker#348 is ready.

@mkmiller
Copy link
Contributor

mkmiller commented Aug 9, 2017

No, at this point anything I would need to modify would have appropriate fallbacks to English (for example I need to update the privacy policy link helper to be locale-aware)

@jmckible jmckible merged commit 5079877 into master Aug 9, 2017
@jmckible jmckible deleted the unpackage-redux branch August 9, 2017 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants