Revert "build: avoid compiling with VS v17.12"

This reverts commit 542f252. PR-URL: nodejs#56151 Refs: nodejs/build#3963 Refs: nodejs#55930 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
technic960183 · Dec 7, 2024 · 6e42433 · 6e42433
1 parent ac7fea6
commit 6e42433
Showing 1 changed file with 1 addition and 10 deletions.
diff --git a/vcbuild.bat b/vcbuild.bat
@@ -292,19 +292,10 @@ goto exit
 @rem Visual Studio v17.10 has a bug that causes the build to fail.
 @rem Check if the version is v17.10 and exit if it is.
 echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
-if %errorlevel% neq 1 (
+if %errorlevel% neq 1  (
   echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
   goto exit
 )
-@rem Same applies to v17.12 for MSVC.
-echo %VSCMD_VER% | findstr /b /c:"17.12" >nul
-if %errorlevel% neq 1 (
-  @rem Clang 18.1.8 Provided with VS 17.12 works fine.
-  if not defined clang_cl (
-    echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version.
-    goto exit
-  )
-)
 
 @rem check if the clang-cl build is requested
 if not defined clang_cl goto clang-skip