Skip to content

fix(lychee): exclude deleted doobidoo/mcp-memory-service (404 on main) - #339

Merged
jphein merged 1 commit into
mainfrom
fix/lychee-doobidoo-404
May 31, 2026
Merged

fix(lychee): exclude deleted doobidoo/mcp-memory-service (404 on main)#339
jphein merged 1 commit into
mainfrom
fix/lychee-doobidoo-404

Conversation

@jphein

@jphein jphein commented May 31, 2026

Copy link
Copy Markdown
Collaborator

The lychee link-check gate is red on main: https://github.com/doobidoo/mcp-memory-service returns 404 (the upstream repo was deleted/renamed). It's referenced as a comparison pointer in README.md (landscape table) and docs/research/2026-05-24-memory-system-benchmarks.md.

Pre-existing on main (added in 5502c1d/9f8a1f7/0aceea3), surfaced when #337's CI ran lychee over the whole repo. The #337 merge greened the count/lint/llms-full/api-docs gates but not this one (the 404 is unrelated to that PR's content, and the exclude landed after the squash-merge).

Added to lychee.toml's existing "external sites that 404 from CI but are intentionally referenced" exclude block — same treatment as kostadis/CampaignGenerator, celiums.ai, etc. Keeps the comparison pointer in the docs (it's an archival reference, not an active dependency) while greening the gate.

Verified locally: the regex matches the failing URL, commit/TBD stays excluded, real commit SHAs are not over-excluded, and lychee.toml parses as valid TOML.

🤖 Generated with Claude Code

The only real lychee error on #337 (CI run 26700068716) was
[404] https://github.com/doobidoo/mcp-memory-service in README.md +
docs/research/2026-05-24-memory-system-benchmarks.md — a comparison
pointer whose upstream repo was deleted/renamed (confirmed 404). It's
pre-existing on main (added in 5502c1d/9f8a1f7/0aceea3, not by #335) so
lychee is red on main too; this greens it for both.

Added to lychee.toml's existing "external sites that 404 from CI but are
intentionally referenced" exclude block, matching kostadis/CampaignGenerator
etc. Verified: the pattern matches the URL, commit/TBD stays excluded, real
commit SHAs are not over-excluded, TOML parses.

(My #335 commit-link fix — HEAD→TBD — already landed in d35b8ad and shows
[EXCLUDED] in the same CI log.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 31, 2026 01:36
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a failing CI link-check gate caused by a 404 error from an upstream repository that has been deleted. By adding the specific URL to the lychee exclusion list, the documentation remains intact as an archival reference while ensuring the CI pipeline passes.

Highlights

  • CI Gate Fix: Updated the lychee configuration to exclude a broken link that was causing the link-check CI gate to fail.
  • Archival Reference Preservation: Added the deleted repository URL to the exclusion list to maintain documentation integrity while resolving the 404 error.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the lychee.toml configuration file to exclude the deleted or renamed upstream repository https://github.com/doobidoo/mcp-memory-service from link checking. There are no review comments, and I have no feedback to provide.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jphein
jphein merged commit 721ea49 into main May 31, 2026
11 of 12 checks passed
@jphein
jphein deleted the fix/lychee-doobidoo-404 branch May 31, 2026 01:42
jphein added a commit that referenced this pull request Jun 10, 2026
…am-2 exclude

- CodeRabbit: stop printing the wake command verbatim — it comes from
  user config and may embed credentials; stderr lands in transcripts
- Gemini: _daemon_healthy catches Exception — urlopen can raise
  ValueError (malformed URL from config) or http.client.HTTPException
  mid-resume, neither of which subclasses OSError
- lychee: 199-biotechnologies/engram-2 was deleted upstream (404 as of
  2026-06-10, pre-existing in three docs this PR never touched) —
  excluded per the doobidoo precedent (#339)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jphein added a commit that referenced this pull request Jun 10, 2026
…st (#345)

* feat(cli): auto_wake — opt-in wake-on-demand for a sleeping palace host

The daemon host is a WoL-armed suspend-to-RAM machine, so connection
refused routinely means asleep. With auto_wake configured in
~/.mempalace/config.json, the CLI's six daemon call sites route through
auto_wake.urlopen_with_wake(): on a connection-level failure it runs
the configured wake command, polls /health until the deadline, and
retries the original request once.

HTTP errors never trigger a wake (404-fallback paths stay intact), the
attempt is once-per-process, PALACE_AUTO_WAKE=0 force-disables, and
malformed config resolves to off — a typo must never make the CLI run
an unexpected shell command. Hooks stay out: they have a latency
budget and pending_queue already journals + replays their failures.

31 new tests (tests/test_auto_wake.py); README count 3877→3908;
changelog + llms-full + python-api regenerated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: api-sidebar.json regen (rides with render-api-docs)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* review(bots) + lychee: no command echo, broad health-poll catch, engram-2 exclude

- CodeRabbit: stop printing the wake command verbatim — it comes from
  user config and may embed credentials; stderr lands in transcripts
- Gemini: _daemon_healthy catches Exception — urlopen can raise
  ValueError (malformed URL from config) or http.client.HTTPException
  mid-resume, neither of which subclasses OSError
- lychee: 199-biotechnologies/engram-2 was deleted upstream (404 as of
  2026-06-10, pre-existing in three docs this PR never touched) —
  excluded per the doobidoo precedent (#339)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants