Skip to content

docs(fork): document .sh shim delegation strategy (#69) - #124

Merged
jphein merged 2 commits into
mainfrom
docs/sh-shim-strategy
May 22, 2026
Merged

docs(fork): document .sh shim delegation strategy (#69)#124
jphein merged 2 commits into
mainfrom
docs/sh-shim-strategy

Conversation

@jphein

@jphein jphein commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Closes/tracks techempower-org/mempalace#69. Documents the fork's counter-position to upstream MemPalace/mempalace#1069:

What's in here

  • docs/fork-decisions/sh-shim-strategy.md — the why (back-compat + ops + graceful absence), the delegation diagram, the shim template, and re-converge conditions.
  • scripts/mempalace-search.sh — non-hook sample of the same delegation pattern (HTTP GET to /search), as a copy-paste template for contributors adding new delegating shims.
  • docs/fork-changes.yamlsh-shim-strategy-doc entry pointing at the docs commit.
  • FORK_CHANGELOG.md — regenerated via scripts/render-docs.py.

No runtime change. The shims this documents (.claude-plugin/hooks/*.sh, .codex-plugin/hooks/*.sh) have been delegating to palace-daemon since the 2026-05-11 split-brain fix; this PR just records the decision.

Test plan

  • bash scripts/check-docs.sh passes (4/4 clean — commit hashes resolve, FORK_CHANGELOG matches YAML, PR-state claims match upstream).
  • scripts/render-docs.py --check exit 0 (rendered docs are idempotent against the YAML).
  • Manual review: shim template in the doc matches the shape of the three live shims (mempal-stop-hook.sh, mempal-precompact-hook.sh, .codex-plugin/hooks/mempal-hook.sh).
  • scripts/mempalace-search.sh syntactically clean (bash -n); intentionally not wired to CI — it's a template, not a feature.

🤖 Generated with Claude Code

jphein added 2 commits May 22, 2026 15:37
Counter-position to upstream MemPalace#1069. Upstream wants
to consolidate the per-event hook .sh wrappers into shims that
delegate to `mempalace hook run`. This fork went the opposite
direction post-2026-05-11: shims delegate to
`palace-daemon/clients/hook.py`, which talks HTTP to a single FastAPI
gateway — `mempalace` is no longer in the hook call path.

docs/fork-decisions/sh-shim-strategy.md captures:
  - why the .sh shims stay (back-compat, ops, graceful absence)
  - why delegation goes through palace-daemon (single-writer gateway)
  - the delegation pattern diagram
  - a copy-paste template
  - re-converge conditions

scripts/mempalace-search.sh is a non-hook sample of the same pattern
(HTTP → /search), for contributors adding new delegating shims.

Refs #69
Adds the sh-shim-strategy-doc entry to docs/fork-changes.yaml
pointing at commit bf0a4d0 (docs + sample shim), and regenerates
FORK_CHANGELOG.md.

Refs #69
Copilot AI review requested due to automatic review settings May 22, 2026 22:40
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jphein
jphein merged commit 3a73aca into main May 22, 2026
8 of 10 checks passed
@jphein
jphein deleted the docs/sh-shim-strategy branch May 22, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants