fix(ci): combine test-linux + test-postgres coverage for 80% threshold (#99) - #121
Merged
Conversation
#99) Each test job uploads its `.coverage` file as a uniquely-named artifact. A new `check-coverage` job downloads them all, runs `coverage combine`, and enforces `--fail-under=80` once against the merged dataset. Removes per-job `--cov-fail-under=79` (workaround introduced in #98 when postgres-backend paths started dragging test-linux coverage down even though test-postgres covers them). - test-linux: matrix uploads `coverage-linux-<py>` artifacts - test-postgres: now runs with `--cov`, uploads `coverage-postgres` - check-coverage: needs both, downloads `coverage-*`, combines, gates 80% Closes #99.
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
pyproject.toml sets [tool.coverage.report] fail_under = 85, which applies to every --cov run. Per-job test runs need --cov-fail-under=0 to disable that; the 80% threshold is enforced only in the combined check-coverage job. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #99. Restores the meaningful 80% coverage threshold by combining coverage artifacts across the matrix instead of enforcing per-job.
Previously each
test-linuxmatrix run enforced--cov-fail-under=79(down from 80 in #98, because postgres-backend paths only run intest-postgres, so adding postgres-only code mechanically dragged test-linux coverage down even when test-postgres covered it at 100%).Changes
test-linux(3.9/3.11/3.13): drops--cov-fail-under, uploads.coverageascoverage-linux-<py>artifacttest-postgres: now runs with--cov=mempalace, uploads.coverageascoverage-postgresartifactcheck-coveragejob:needs: [test-linux, test-postgres], downloads allcoverage-*artifacts, runscoverage combine+coverage report --fail-under=80cov-fail-under: 79explanatory comment blocks from all three matrix-job sitesThe single threshold gate now sees the union of test-linux and test-postgres coverage, so:
Test plan
check-coveragejob is itself the validation — if it doesn't fail at 80%, the combine worked)