fix: venv path + test count + check-docs regex (#114, #117) - #119
Conversation
- render-docs.py: changelog header and commit_link() now point at techempower-org/mempalace so the FORK_CHANGELOG regenerates with the correct repo slug. - check-docs.sh: cross-repo URL filter accepts both jphein/ and techempower-org/ slugs while the YAML body still carries historical jphein/ narrative; the retired-check comment updated for symmetry. - README.md: sweep all https://github.com/jphein/mempalace and https://github.com/jphein/palace-daemon URLs to their techempower-org equivalents (PR links, commit links, deployment-runs-at slug). - FORK_CHANGELOG.md: regenerated from docs/fork-changes.yaml so every rendered commit link resolves to techempower-org/mempalace; the historical body text inside YAML entries is unchanged. Historical narrative ("transferred from jphein/mempalace in May 2026") and links to other personal forks (jphein/familiar.realm.watch, jphein/notebook, etc.) stay as-is — only the two repos that actually moved to techempower-org are rewritten. Closes #118
…e ChromaDB references - docs/fork-changes.yaml: PR MemPalace#1024 (configurable chunking) moved from OPEN to MERGED with merged_date 2026-05-15; added to merged_upstream entries so the FORK_CHANGELOG recently-merged section reflects the 2026-05-15 upstream land. - docs/fork-changes.yaml: PR MemPalace#1085 (batched ChromaDB inserts cherry-pick) moved from OPEN to CLOSED with body note that @midweste closed it 2026-05-16, superseded by merged upstream MemPalace#1185 (wider GPU-acceleration scope). Fork's 6be6fff is now a no-op against develop. - CLAUDE.md: Key Files block rewrites the stale "ChromaDB vector store. The actual data." line to point at postgres on disks.jphe.in via palace-daemon and reference the 2026-05-14 cutover + RETIRED marker. - CLAUDE.md: Two-Layer Memory Architecture line updates MemPalace storage from "~/.mempalace/palace/, ~183K drawers" to the production postgres + pgvector + AGE on disks.jphe.in with a normalized "300K+" drawer count. README.md drawer-count normalization (160K/273K/274K -> 300K+) and ChromaDB->pgvector edits landed in efcb5c6 alongside the #118 URL sweep. FORK_CHANGELOG.md regenerates clean from the updated YAML. Closes #115, #116
The README test-count drift check in scripts/check-docs.sh anchored its regex at start-of-line, but the count lives mid-paragraph on README:28. The check silently no-op'd, letting "~1850 tests pass on main" drift to 2486 actual without a single warning (#114). De-anchor the regex; the rest of the pipeline already does the right thing (counts via pytest --collect-only). Also converge on .venv/ — the project's actual venv path — instead of the dead venv/ path hard-coded in scripts/check-docs.sh and scripts/preflight.sh. Fixes the silent fallback-to-PATH behavior that masked the wrong path for so long (#117). CLAUDE.md:59 was already inconsistent with :46 — both now say .venv. Refs: #114, #117
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the virtual environment directory naming convention to .venv/ across the repository and updates various documentation files to reflect current test counts and organizational transitions. Additionally, it refines the check-docs.sh script to improve the reliability of the documentation drift detection mechanism. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project's documentation and maintenance scripts to reflect the migration to a Postgres-based backend, the repository's transfer to the techempower-org organization, and the transition to a .venv directory for local development. A bug was identified in the documentation verification script where a regex was overly broad and failed to account for diverse repository naming conventions, potentially skipping necessary commit hash validations.
| mapfile -t hashes < <( | ||
| for d in "${docs[@]}"; do | ||
| grep -v -E 'palace-daemon|multipass-structural-memory-eval|/jphein/[a-z-]+/commit/' "$d" 2>/dev/null | ||
| grep -v -E 'palace-daemon|multipass-structural-memory-eval|/(jphein|techempower-org)/[a-z-]+/commit/' "$d" 2>/dev/null |
There was a problem hiding this comment.
The updated regex /(jphein|techempower-org)/[a-z-]+/commit/ is too broad because it matches the current repository (techempower-org/mempalace/commit/). This causes grep -v to skip lines in the changelog that contain links to this repo's own commits, meaning those hashes are never verified by the script. Additionally, [a-z-]+ misses repositories with numbers (e.g., engram-2) or uppercase letters (e.g., GraphPalace).
To fix this without using Perl-compatible regex (which isn't portable to all grep versions), you can use sed to mask the current repo's URLs before filtering out other commit links.
| grep -v -E 'palace-daemon|multipass-structural-memory-eval|/(jphein|techempower-org)/[a-z-]+/commit/' "$d" 2>/dev/null | |
| sed 's|/techempower-org/mempalace/commit/|/INTERNAL/|g' "$d" | grep -v -E 'palace-daemon|multipass-structural-memory-eval|/(jphein|techempower-org)/[A-Za-z0-9_-]+/commit/' 2>/dev/null |
Summary
.venv/consistently (wasvenv/)Closes #114, closes #117.
Test plan
./scripts/check-docs.shpasses all 4 checks🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com