Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Request ID to Sentry #22

Open
zupo opened this issue Mar 9, 2019 · 4 comments
Open

Send Request ID to Sentry #22

zupo opened this issue Mar 9, 2019 · 4 comments

Comments

@zupo
Copy link
Member

zupo commented Mar 9, 2019

First, read https://blog.sentry.io/2019/01/31/using-nginx-sentry-trace-errors-logs.
Second, read https://devcenter.heroku.com/articles/http-request-id.

Then here's the idea: add a tween to this package that, if Sentry is imported, binds the Request ID for all error reports. Also, if structlog is imported, it binds the Request ID for all logs..
@sourya
Copy link

sourya commented Sep 4, 2019

Hey @zupo, is it okay if I work on this?

@zupo
Copy link
Member Author

zupo commented Sep 4, 2019

Sure go ahead!

sourya pushed a commit to sourya/pyramid_heroku that referenced this issue Sep 10, 2019
@sourya-deepsource
[Fix teamniteo#22] Add request_id...
d931b96 
... to sentry and structlog logs

Signed-off-by: Sourya Vatsyayan <[email protected]>
sourya pushed a commit to sourya/pyramid_heroku that referenced this issue Sep 10, 2019
@sourya-deepsource
[Fix teamniteo#22] Add request_id...
ffd1af9 
... to sentry and structlog logs

Signed-off-by: Sourya Vatsyayan <[email protected]>
sourya pushed a commit to sourya/pyramid_heroku that referenced this issue Sep 10, 2019
@sourya-deepsource
[Fix teamniteo#22] Add request_id...
6c764bd 
... to sentry and structlog logs

Signed-off-by: Sourya Vatsyayan <[email protected]>
@shawnwang-avl
Copy link

Is this abandoned?

@zupo
Copy link
Member Author

zupo commented Nov 4, 2022

Abandoned in the sense that noone is currently working on it: yes.
Abandoned in the sense that it is no longer a valid issue: no, this is a great addition to pyramid_heroku!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zupo @sourya @shawnwang-avl