Repository navigation
runner-hook: a whole-mini claim names the hook that admitted the job - #1739
Merged
Merged
Conversation
…(GLAEDA_HOOK_SHA256) The exclusive claim in $GITHUB_ENV now carries this hook file's sha256 beside GLAEDA_JOB_CLAIM=exclusive, so a signing job can refuse itself when an older hook (one without the leftover-process check) admitted it. A hook that cannot read itself writes no sha. Pins the hook's new sha256 in glaeda-disk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
Owner
Author
|
Owned by an agent session · session |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leo, 2026-10-28: the release signing jobs may run on owned Macs, on a mini the job "claims exclusively".
The exclusive class's leftover-process check (#1738) only holds on minis whose runner dirs carry the new hook; a runner dir still on an older hook admits a signing job without it. This makes the claim name the hook that granted it, so cmux's signing jobs can refuse themselves (and fall back to Blacksmith in the same run) when an older hook admitted them.
export_job_claimwritesGLAEDA_HOOK_SHA256=<sha256 of this hook file>besideGLAEDA_JOB_CLAIM=exclusive.41e29cd9…) in glaeda-disk.Before:
$GITHUB_ENVgetsGLAEDA_JOB_CLAIM=exclusive. After: it also getsGLAEDA_HOOK_SHA256=41e29cd9….Tests:
test_job_claim_names_only_a_whole_mini(both lines, and no sha for an unreadable hook) andtest_a_signing_job_takes_the_whole_mini(an admitted signing job sees the sha) pass, as do the hook-pin and glaeda-disk hook tests.Not in this PR: swapping a staged hook in at job start. It is left out on purpose.
Agent session: agent session
🤖 Generated with Claude Code