Skip to content

glaeda-gh: over 100 checks, a held check still waits for its rescue (no bead) - #1471

Merged
teamleaderleo merged 4 commits into
mainfrom
gh-truncated-held
Oct 14, 2026
Merged

teamleaderleo merged 4 commits into
mainfrom
gh-truncated-held

Conversation

@teamleaderleo

Copy link
Copy Markdown
Owner

Summary

A PR with more than 100 checks (checksTruncated) skipped the held/pending logic: GitHub's rollup decided alone. manaflow-ai/cmux#20733 showed "0 failed, 13 pending, 1 held" and still exited 1, because the rescue had cancelled its queued fast tier and the rollup reads a cancelled check as FAILURE.

Now, over 100 checks, the rollup still decides, except:

  • a FAILURE waits while a shown check is held for its rescue (RESCUE_GRACE), and, with --until done, while a shown check still runs;
  • a shown check that really failed still fails at once;
  • with nothing shown held or failed, a FAILURE is a check past the first 100 and fails as before.

Verification

python3 scripts/test-glaeda-gh.py: the new test_over_100_checks_a_held_check_still_waits_for_its_rescue was committed first and failed (1 is not None), then passed; all 78 tests pass.

🤖 Generated with Claude Code

teamleaderleo and others added 4 commits October 14, 2026 13:53
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…LURE (no bead)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ng siblings (no bead)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo merged commit 90830be into main Oct 14, 2026
3 checks passed
@teamleaderleo
teamleaderleo deleted the gh-truncated-held branch October 14, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant