Repository navigation
cmux-runner-hook: a locked console skips the frame-pacing bench instead of failing it - #1384
Merged
Merged
Conversation
Fails today: admission refuses the bench (gui-step) on a locked console, which fails the nightly since it has no other runner or rescue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RYQHfug1ZVQDp4eWgwVUtD
The bench runs on the side-lane mini or not at all, so a console refusal only failed the nightly. Admitted as light with no gui token, its take-gui step gives way (exit 3) and the workflow skips the console steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RYQHfug1ZVQDp4eWgwVUtD
Owner
Author
|
Subagent review at b3a17fc: APPROVE.
Nits, none blocking:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the console session is locked, the cmux-next frame-pacing
benchjob (cmux#16511) is now admitted and skips its console steps, where it used to be refused and fail.gui-step, admission's console refusal turned a locked mini into a red nightly.CONSOLE_SKIPPERSset (("cmux-next-frame-pacing.yml", "bench")) lists console jobs that skip their own console steps whentake-guigives way. On a locked console, job-started admits such a job aslight, with no gui token, and logs why.take-gui --wait 900step then gives way (exit 3,console: ... screen-locked). The workflow already maps that totaken=falseand skips every console step with a notice, so the job ends green.test, anything on--gui-runner) is still refused, so cmux's rescue re-runs it elsewhere.The cmux workflow needs no change: its gui step already treats any
take-guiexit other than 0 or 2 as a skip.Red / green
python3 scripts/test-glaeda-cmux-runner.py HookTest.test_a_locked_console_leaves_the_frame_pacing_bench_to_skip_itselfRan 1 test ... OK.Locally,
HookTest.test_a_locked_console_refuses_gui_jobs_before_taking_capacity,NoEmDashTestandConsoleTestalso pass. CI runs the full suite.🤖 Generated with Claude Code
https://claude.ai/code/session_01RYQHfug1ZVQDp4eWgwVUtD