Repository navigation
glaeda-cmux-runner-hook: compile-gui takes the gui token only for its tests - #1267
Merged
Merged
Conversation
… tests test-e2e's build held the gui token from job start, through its compile, so every other GUI job on the mini waited out GUI_WAIT_S and was refused while it compiled (run 36184794966: an E2E build refused for the gui token on cmux11s). cmux#14705 has the build's test-decision step take the token with take-gui and hand the tests to the test job when it gives way or times out, so compile-gui now costs 2 units and a root only. Merge only after cmux#14705 is on main: a build without that step would run its tests without the token. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge before manaflow-ai/cmux#14705 is on main. Until then the E2E build runs its tests without taking the token itself.
test-e2e's
build(compile-gui) held the mini's gui token from job start, through its whole compile. Every other GUI job on that mini waited outGUI_WAIT_S(60 s) and was refused. Run 36184794966's own E2E build was refused on cmux11s that way (capacity: the gui token is taken (build is compile-gui)).manaflow-ai/cmux#14705 moves the token to the build's test-decision step, which calls
glaeda-canonical-root take-gui --wait 300(from #1260, deployed). If take-gui gives way (exit 3) or times out (exit 1), that step hands the tests to thetestjob. With that in place, compile-gui here costs 2 units and a root, and no gui token.Unchanged:
test(gui) still takes gui at job start.ROOT_SWITCHERS, the root-1 preference and--switchare untouched.Tests
test_capacity_e2e_build_takes_the_gui_token_for_its_tests_onlyreplaces the old gui-at-admission test. It covers:testjobscripts/test-glaeda-cmux-runner.py: full suite OK.Rollout
After the cmux PR merges: merge this, then
scripts/glaeda-cmux-runner-fleet --apply --org manaflow-ai --group glaeda-minis, canary first.🤖 Generated with Claude Code