glaeda-cmux-runner-hook: class jobs by workflow file + job id where ids collide - #1238
Merged
Merged
Conversation
… ids collide cmux-tui.yml's macOS lint, test and build (about 117 runs a week) share job ids with test-e2e's root jobs, so the hook costed them as unknown compiles pinned to the canonical root. WORKFLOW_JOB_CLASSES, read from GITHUB_WORKFLOW_REF's file, is checked first: cmux-tui's three are isolated, app-host-test-rerun's rerun is product. Everything else is unchanged; release-build stays the safe default until its paths are audited. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ned default It hard-codes /private/tmp/cmux-ci, deletes compile admission's DerivedData and never takes a root, so product (which drops the root token when roots > 1) would let it clobber root 1. Keep compile, pinned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The job-start hook classes a job by
GITHUB_JOBalone, and an unknown id counts as a compile pinned to the canonical root. cmux-tui.yml's macOSlint/test/build(about 117 runs a week; see manaflow-ai/cmux#14411) collide with test-e2e'sbuild/testroot jobs, so they hold a root and the persistent-DerivedData token for a cargo build.What
WORKFLOW_JOB_CLASSESkeyed on (workflow file, job id), checked beforeJOB_CLASSES. The file comes fromGITHUB_WORKFLOW_REF, which names the caller workflow for reusable ones (cmux-tui's build-artifactsbuild). Missing or malformed: falls back to the id-only rule.lint,test,build: isolated (cargo into the workspace target; no GUI, root, persistent DerivedData or simulator).rerundeliberately stays the default (compile, pinned): it hard-codes /private/tmp/cmux-ci, deletes compile admission's DerivedData and never takes a root. Giving it a better class needs the cmux workflow to honor CMUX_CI_CANONICAL_ROOT and take its root first. It routes to Blacksmith today anyway.Tests
New
test_job_class_keys_on_workflow_file_and_job_id; full suite 115 OK.🤖 Generated with Claude Code