Repository navigation
Stabilize native hot-run file readiness tests - #1086
Merged
Merged
Conversation
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the mainline native hot-run test race observed in Verify run 35634307082.
The helper previously returned as soon as a child-created path became readable. Python opens/truncates the file before its buffered write is visible, so the test could observe an empty file and panic at
worker.next().unwrap(); the shared mutex then poisoned and cascaded five more failures.This changes only the test helper: it waits until the file is readable and non-empty. All existing callers immediately parse PID/group content, so path existence alone was never sufficient readiness evidence.
No production behavior, resource policy, cgroup settings, or execution authority changes.