Repository navigation
refactor: inject Cloud terminal navigation capabilities - #92
Closed
teamleaderleo wants to merge 6 commits into
Closed
teamleaderleo wants to merge 6 commits into
teamleaderleo wants to merge 6 commits into
Conversation
Owner
Author
|
Superseded by the active upstream PR manaflow-ai#13264 on manaflow-ai/cmux:refactor/cloud-navigation-capabilities. The exact six commits and head 9401fe5 are preserved. Candidate native verification remains in progress and all further fixes, review, and evidence belong on the upstream PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cloud terminal navigation currently names the concrete catalog and global app/window helpers, so testing its restore policy requires the app's runtime owners. This prototype gives the Cloud consumer narrow catalog, presentation and keyed-scheduling capabilities. The existing SurfaceCatalog and AppDelegate adapters perform the same operations; navigation retains validation, restore/bind ordering and exact daemon-tab selection.
This is one bounded cut from RFC #13108, coordinated through Tact #80. Tact #81 retains identity mapping/fixtures ownership.
Scope and dependency removal
CloudTreeTerminalNavigationCoordinatorno longer depends on concreteSurfaceCatalog,AppDelegate,SurfacePaneFactory,CloudTreeNodeBuilder,CloudWorkspaceLayoutTranslator, orCloudTreeNodeActions.Validation (in progress)
Characterization commit
3f12f35158precedes the inversion and covers invalid owners, duplicate activation and real-catalog projection reuse. Fake-capability tests add exact clicked-tab restore, ambiguity/missing-target failure, deletion checks, cancellation cleanup, unavailable scheduling and original error propagation. Existing entrypoint/integration tests remain wired.Project normalization, test wiring, and diff whitespace checks pass. Native app/CLI and cmux-unit execution are pending the serialized local build lane; no runtime pass is claimed yet. Exact results and timing receipts will be added before handoff.
Pending decision and next cut
manaflow-ai#13119 was closed in favor of #13135, which remains open and is absent from this base. Its package extraction and historical measurements are not repeated here. This prototype keeps navigation in the app target; the value package,
SurfaceResourceGroup/layout declaration closure, and operation scheduling/recording are prerequisites to a later packaged Cloud navigation slice. There is no claimed package-build speedup or public API/schema change.Maintainer decision: accept this consumer-owned navigation boundary for the RFC's second cut, then decide the landing order with manaflow-ai#13135. This draft is in the user's fork pending that decision and native evidence. No merge is requested.
The comparison base
prototype/cloud-navigation-basepins upstream mainb334a7deeb0ff65bc9ee4d1c6a2bf7d454795110; the fork's main is much older, so using it would add thousands of unrelated files to this review.