Feat extend user import #1992
Merged
Feat extend user import #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add custom user ID to a user. This custom user ID is only used for verifying assertions from imported passkeys.
Change the DB schema to restrict a user handle to only one user.
Co-authored-by: bjoern-m <[email protected]>
Co-authored-by: bjoern-m <[email protected]>
Apply unique constraint to the column handle in table webauthn_credential_user_handles.
bjoern-m
reviewed
Dec 9, 2024
backend/cmd/user/format.go
Outdated
| @@ -26,16 +26,76 @@ func (ImportOrExportEmail) JSONSchemaExtend(schema *jsonschema.Schema) { | |||
| // Emails Array of email addresses | |||
| type Emails []ImportOrExportEmail | |||
|
|
|||
| type ImportWebauthnCredential struct { | |||
| // ID of the webauthn credential. | |||
There was a problem hiding this comment.
Suggested change
| // ID of the webauthn credential. | |
| // ID of the WebAuthn credential. |
There are multiple occurrences across this PR.
Fix user import with multiple credential and the same user handle. Check if the user handle already exists and associate the credential with it otherwise create a new user handle in the database.
bjoern-m
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the user import to import existing passwords, webauthn credentials, ...
Implementation
Extended the already existing import command to include more information.
Tests
Create a json file with users to import, then use the import command to import the users.