Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-api): return webauthn transports in users endpoints #1652

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

lfleischmann
Copy link
Member

Description

Our OpenAPI Admin Spec claims that on /users endpoints for retrieving user information, the webauthn_credentials contain a transports array for every credential. While the key is present in an API response, the value is alwas an empty array because the transports are not preloaded by pop.

Implementation

Eager preload the transports in the corresponding UserPersister methods.

@lfleischmann lfleischmann merged commit b3a4355 into main Sep 30, 2024
8 checks passed
@lfleischmann lfleischmann deleted the fix-admin-return-webauthn-transports branch September 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants