Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update puma registration for latest master #2530

Merged
merged 2 commits into from
Oct 15, 2022
Merged

Update puma registration for latest master #2530

merged 2 commits into from
Oct 15, 2022

Conversation

twalpole
Copy link
Member

This is a WIP -- waiting to see what other changes are made to Puma

@nateberkopec
Copy link

We're finalizing Puma 6.0, whatever's on Puma master will be what makes it in, so you can finalize this now 👍

@elalemanyo
Copy link

elalemanyo commented Oct 14, 2022 •
edited
Loading

Using this branch fixes the issues with Puma::Events.strings and Puma::Events.stdio but I get now another error:

shot2022-10-14 at 10 10 15@2x

I think the problem has to do with lib/capybara/registrations/servers.rb:44

@twalpole twalpole force-pushed the puma_master_changes branch from 551d9bf to de2f221 Compare October 15, 2022 22:44
@twalpole twalpole marked this pull request as ready for review October 15, 2022 22:51
@twalpole twalpole merged commit 797ea0b into master Oct 15, 2022
@twalpole twalpole mentioned this pull request Oct 15, 2022
Closed
@davidrunger davidrunger mentioned this pull request Oct 16, 2022
Closed
@marocchino marocchino mentioned this pull request Oct 17, 2022
Merged
@cpjmcquillan cpjmcquillan mentioned this pull request Oct 17, 2022
Closed
@skelz0r skelz0r mentioned this pull request Oct 17, 2022
Merged
@simi simi mentioned this pull request Oct 18, 2022
Closed
@thomasleese thomasleese mentioned this pull request Oct 18, 2022
Merged
@simi simi mentioned this pull request Oct 18, 2022
Closed
@amiel
Copy link

amiel commented Oct 18, 2022

Without this fix, we're blocked from upgrading puma. Any chance of a release?

Thanks!

@twalpole
Copy link
Member Author

twalpole commented Oct 18, 2022 •
edited
Loading

@amiel options

  1. Use the master branch. It’s not a gem generally used in production so no risk to using an unreleased version
  2. Write your own server registration and use that rather than the default ones provided by Capybara
  3. Don’t upgrade to puma 6 yet. There are no security issues in latest 5.x and no groundbreaking changes in 6 for 95% of users so what’s the drive to update NOW
  4. Fork this repo and release your own gem under a new name
  5. Wait until I have time to do a release on my schedule

Pick one, posting on closed issues helps nobody

@StasShk StasShk mentioned this pull request Oct 19, 2022
Merged
@lmansur lmansur mentioned this pull request Oct 19, 2022
Closed
@amiel
Copy link

amiel commented Oct 19, 2022

Hi @twalpole. As I re-read my comment, I see how it was perceived as impatience, which I apologize for. I did not intend this, but here we are.

I will for sure wait and look forward to a release that includes this change.

FWIW, I appreciate your time and effort maintaining cabybara, from which I have made use of across many projects over the years. Thank you!

@zspencer zspencer mentioned this pull request Oct 19, 2022
Closed
@just1602 just1602 mentioned this pull request Oct 21, 2022
Merged
@koi-chan koi-chan mentioned this pull request Oct 25, 2022
Merged
@brenetic brenetic mentioned this pull request Oct 26, 2022
Merged
kevindew added a commit to alphagov/whitehall that referenced this pull request Oct 27, 2022
@kevindew
Make govuk_app_config conservative
c1537ce 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1], I'm
hoping that this is a sub-dependency it'll just be updated soon and not
be of concern.

I'm hoping to avoid a pin as we don't have a direct dependency on puma
currently.

[1]: teamcapybara/capybara#2530
kevindew added a commit to alphagov/content-tagger that referenced this pull request Oct 28, 2022
@kevindew
Make govuk_app_config update conservative
ed8a6b5 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1], I'm
hoping that this is a sub-dependency it'll just be updated soon and not
be of concern.

I'm hoping to avoid a pin as we don't have a direct dependency on puma
currently.

[1]: teamcapybara/capybara#2530
kevindew added a commit to alphagov/signon that referenced this pull request Oct 28, 2022
@kevindew
Make govuk_app_config conservative
1b9e9f7 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1], I'm
hoping that this is a sub-dependency it'll just be updated soon and not
be of concern.

I'm hoping to avoid a pin as we don't have a direct dependency on puma
currently.

[1]: teamcapybara/capybara#2530
kevindew added a commit to alphagov/transition that referenced this pull request Oct 28, 2022
@kevindew
Make govuk_app_config conservative
0abbd53 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1], I'm
hoping that this is a sub-dependency it'll just be updated soon and not
be of concern.

I'm hoping to avoid a pin as we don't have a direct dependency on puma
currently.

[1]: teamcapybara/capybara#2530
kevindew added a commit to alphagov/publisher that referenced this pull request Nov 2, 2022
@kevindew
Make govuk_app_config conservative
f79b1e1 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1], I'm
hoping that this is a sub-dependency it'll just be updated soon and not
be of concern.

I'm hoping to avoid a pin as we don't have a direct dependency on puma
currently.

[1]: teamcapybara/capybara#2530
kevindew added a commit to alphagov/manuals-publisher that referenced this pull request Nov 2, 2022
@kevindew
Make govuk_app_config conservative
62b4672 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1], I'm
hoping that this is a sub-dependency it'll just be updated soon and not
be of concern.

I'm hoping to avoid a pin as we don't have a direct dependency on puma
currently.

[1]: teamcapybara/capybara#2530
kevindew added a commit to alphagov/travel-advice-publisher that referenced this pull request Nov 2, 2022
@kevindew
Make govuk_app_config conservative
33c96b7 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1], I'm
hoping that this is a sub-dependency it'll just be updated soon and not
be of concern.

I'm hoping to avoid a pin as we don't have a direct dependency on puma
currently.

[1]: teamcapybara/capybara#2530
kevindew added a commit to alphagov/content-publisher that referenced this pull request Nov 2, 2022
@kevindew
Make govuk_app_config conservative
562aa64 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1], I'm
hoping that this is a sub-dependency it'll just be updated soon and not
be of concern.

I'm hoping to avoid a pin as we don't have a direct dependency on puma
currently.

[1]: teamcapybara/capybara#2530
kevindew added a commit to alphagov/collections-publisher that referenced this pull request Nov 2, 2022
@kevindew
Make govuk_app_config conservative
12d3e6d 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1], I'm
hoping that this is a sub-dependency it'll just be updated soon and not
be of concern.

I'm hoping to avoid a pin as we don't have a direct dependency on puma
currently.

[1]: teamcapybara/capybara#2530
chao-xian added a commit to alphagov/government-frontend that referenced this pull request Nov 3, 2022
@chao-xian
Make govuk_app_config use Puma 5
ada2c48 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1]

[1]: teamcapybara/capybara#2530
chao-xian added a commit to alphagov/frontend that referenced this pull request Nov 3, 2022
@chao-xian
Make govuk_app_config use Puma 5
58a39e3 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1]

[1]: teamcapybara/capybara#2530
chao-xian added a commit to alphagov/static that referenced this pull request Nov 3, 2022
@chao-xian
Make govuk_app_config use Puma 5
3fe92e8 
The capybara gem is currently not compatible with Puma 6 and thus this
gem update can't go ahead.

Capybara already has a fix for this which hasn't been released [1]

[1]: teamcapybara/capybara#2530
@twalpole
Copy link
Member Author

twalpole commented Nov 4, 2022

3.38.0 has been released

chao-xian added a commit to alphagov/static that referenced this pull request Nov 14, 2022
@chao-xian
Update to latest Capybara
cb5b9ae 
This allows us to move to the latest version of Puma [1].

[1]: teamcapybara/capybara#2530
@chao-xian chao-xian mentioned this pull request Nov 14, 2022
Merged
chao-xian added a commit to alphagov/static that referenced this pull request Nov 14, 2022
@chao-xian
Update to latest Capybara
c7371d2 
Capybara 3.38.0

This allows us to move to the latest version of Puma [1].

[1]: teamcapybara/capybara#2530
cpjmcquillan added a commit to ministryofjustice/laa-apply-for-legal-aid that referenced this pull request Nov 16, 2022
@cpjmcquillan
Update Puma to v6.0
afbedd4 
This is a [major update] of arguably the most important part of our application
(the webserver), so proceed with caution!

[major update]: https://github.com/puma/puma/releases/tag/v6.0.0

It looks like the only breaking change that impacted us was the one that broke
Capybara. This has since been [resolved] and [released].

[resolved]: teamcapybara/capybara#2530
[released]: https://github.com/teamcapybara/capybara/releases/tag/3.38.0

CI is green, but theres no place quite like production. This change should be
sanity checked in UAT and Staging environments, and monitored in Production.
@cpjmcquillan cpjmcquillan mentioned this pull request Nov 16, 2022
Merged
cpjmcquillan added a commit to ministryofjustice/laa-apply-for-legal-aid that referenced this pull request Nov 16, 2022
@cpjmcquillan
Update Puma to v6.0
3b77998 
This is a [major update][major update] of arguably the most important part of our application
(the webserver), so proceed with caution!

[major update]: https://github.com/puma/puma/releases/tag/v6.0.0

It looks like the only breaking change that impacted us was the one that broke
Capybara. This has since been [resolved][resolved] and [released][released].

[resolved]: teamcapybara/capybara#2530
[released]: https://github.com/teamcapybara/capybara/releases/tag/3.38.0

CI is green, but theres no place quite like production. This change should be
sanity checked in UAT and Staging environments, and monitored in Production.
cpjmcquillan added a commit to ministryofjustice/laa-apply-for-legal-aid that referenced this pull request Nov 16, 2022
@cpjmcquillan
Update Puma to v6.0
9232146 
This is a [major update](https://github.com/puma/puma/releases/tag/v6.0.0) of
arguably the most important part of our application (the webserver), so
proceed with caution!

It looks like the only breaking change that impacted us was the one that broke
Capybara. This has since been
[resolved](teamcapybara/capybara#2530) and
[released](https://github.com/teamcapybara/capybara/releases/tag/3.38.0).

CI is green, but theres no place quite like production. This change should be
sanity checked in UAT and Staging environments, and monitored in Production.
@urimaro urimaro mentioned this pull request Nov 18, 2022
Merged
camillevilla added a commit to department-of-veterans-affairs/diffusion-marketplace that referenced this pull request Dec 20, 2023
@camillevilla
Bump Capybara to 3.39.2 to resolve puma issues in CI
9ccc951 
teamcapybara/capybara#2530
teamcapybara/capybara@3.37.1...3.39.2
camillevilla added a commit to department-of-veterans-affairs/diffusion-marketplace that referenced this pull request Dec 21, 2023
@camillevilla
Bump puma to 6.4.0 (#755)
9a52897 
* Bump puma to 6.4.0

* Bump Capybara to 3.39.2 to resolve puma issues in CI

teamcapybara/capybara#2530
teamcapybara/capybara@3.37.1...3.39.2

---------

Co-authored-by: Camille Villa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twalpole @nateberkopec @elalemanyo @amiel