Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tag-from-scope), merge package.json props from the last snap #9207

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

davidfirst
Copy link
Member

The need came from Angular components. Angular env uses ng-packgr to compile components during build, this tool modifies the package.json and adds different values into exports prop. Because the modification is done during build pipeline and is not saved as an artifact, it gets lost when tagging from scope.
As a reminder, tag-from-scope copies artifacts from the last snap into the capsule and only runs the tag-pipeline.
This PR, uses the package.json saved in the last snap and merge its properties into the current package.json of the capsule. It can't simply replace it, because some values, such as version and dependencies versions are changed in this tag.

@GiladShoham GiladShoham merged commit fb875ca into master Sep 22, 2024
9 of 11 checks passed
@GiladShoham GiladShoham deleted the merge-pkg-json-last-build branch September 22, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants