Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export), fix output to show the exported lane in case no new snaps added #9175

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

davidfirst
Copy link
Member

In some cases, the export doesn't bring any new component or snap/tag to the remote, but it does update the lane object. It happens for example in the following two cases:

  1. when a lane has forked from another lane and exported immediately to the same scope, without adding new snaps.
  2. when merging another lane where all snaps already in the remote.

Until now, it was showing "nothing to export" for both cases above. The first case actually didn't do any action and nothing was exported, the second case the message is misleading because the lane object itself was exported.

This PR fix both cases. The first case is now exporting the new lane to the remote and for both cases it shows the message "exported the lane xxx/yyy" in the output.

@davidfirst davidfirst merged commit 64697ee into master Sep 5, 2024
11 checks passed
@davidfirst davidfirst deleted the export-output-no-id-lane branch September 5, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants