Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(envs) - load envs of envs before loading the envs #9138

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Aug 22, 2024

Proposed Changes

  • This will make sure that when loading a group of components we load the envs in the correct order in case we have envs of envs. See the following example
CompA uses ReactEnv
CompB uses ReactEnv
ReactEnv uses BitEnv

Until now the loading groups were:

[
  [ReactEnv, BitEnv],
  [CompA, CompB]
]

So ReactEnv and BitEnv were in the same group.
After this change it will look like this:

[
  [BitEnv],
  [ReactEnv],
  [CompA, CompB]
]
  • This should also fix the annyoning warning:
environment with ID: bitdev.general/envs/[email protected] configured on component my-custom-env@version was not loaded (run "bit install")

@GiladShoham GiladShoham enabled auto-merge (squash) August 22, 2024 11:24
@GiladShoham GiladShoham merged commit 8fd3b05 into master Aug 22, 2024
11 checks passed
@GiladShoham GiladShoham deleted the fix-load-envs-of-envs branch August 22, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants