Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview): trigger onLoad event on webpack compilation errors #9109

Merged
merged 10 commits into from
Aug 12, 2024

Conversation

luvkapur
Copy link
Member

@luvkapur luvkapur commented Aug 9, 2024

This PR updates the Component Preview to invoke the onLoad event when it receives a message from webpack about any compilation errors in the preview (both during first load and HMR).

CR: https://bit.cloud/bitdev/react/~change-requests/report-webpack-error-browser

Screen.Recording.2024-08-09.at.1.28.35.PM.mov

@luvkapur luvkapur enabled auto-merge (squash) August 12, 2024 15:51
@luvkapur luvkapur merged commit 7ce19b8 into master Aug 12, 2024
11 checks passed
@luvkapur luvkapur deleted the preview-webpack-error branch August 12, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants