feat, introduce "local-only" feature to keep components locally for local debugging/test purposes #9057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiladShoham
approved these changes
Jul 22, 2024
davidfirst
added a commit
that referenced
this pull request
Jul 23, 2024
…ome ids are local-only (#9059) also, remove the --include-local-only flag. This is related to the recently-merged local-only feature: #9057. The original implementation has two issues: 1. It's possible to snap/tag local-only components with `--include-local-only` flag. Then, the export filters them out. However, what if it has been unset later on, snapped again and exported. The remote doesn't have part of the history which was local-only back then. 2. when on a lane and some local-only components were snapped with the flag above, the export sends a lane object to the remote with some components that exist only locally. This PR handles the issues above by the follwoing: 1. removes the `--include-local-only` flag, so it's impossible to snap/tag local-only components. 2. block `bit local-only set` from running on staged components. 3. just in case somehow a component was managed to be local-only when it's staged, `bit export` blocks the export and suggests running `bit reset` or `bit local-only unset`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
bit local-only set <pattern>(undo bylocal-only unset, list bylocal-only list).--include-local-onlywas used for snap/tag).bit statusshows a new section "local only components".$localOnly. Can be used for all commands that support pattern.Edit: some specs have changed in a later PR: #9059