Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to set a custom bit roots directory #9053

Merged
merged 10 commits into from
Jul 23, 2024

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Jul 18, 2024

Proposed Changes

@zkochan zkochan marked this pull request as ready for review July 22, 2024 09:56
const relativePath = this.dependencyResolver.getRuntimeModulePath(component);
const relativePath = this.dependencyResolver.getRuntimeModulePath(component, {
workspacePath: this.workspace.path,
rootComponentsPath: this.workspace.rootComponentsPath,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you need the isInWorkspace prop here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I don't need it as it wasn't here before my changes.

* Get the location of the bit roots folder
*/
get rootComponentsPath() {
return path.join(this.config.rootComponentsDirectory ?? this.modulesPath, BIT_ROOTS_DIR);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something looks missing to me here
in case it was configured you don't have the workspace path.
if it's not configured you will have
/path-to-workspace/node_modules/.bit_roots
if it's configured, you will have
/configured-path/.bit_roots
without the workspace path in the beginning

@GiladShoham GiladShoham merged commit e164e44 into teambit:master Jul 23, 2024
11 checks passed
@zkochan zkochan deleted the fix-custom-root-comps-dir-2 branch July 23, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants