change Version hash to be auto-generated and not based on content #8887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the legacy it was completely based on hashing part of the content. Since Harmony, only tag (not snap) used this calculation and only for the first time. Once generated, the hash was saved as part of the object and was used purely by the hash prop and not by the calculation.
This PR completes the transition by aligning tag and snap and always auto-generating the hash by a random UUID.
(the reason this was done now is because I have noticed a very rare occurrence when an e2e-test was creating two components with the exact same files and their tag hashes were identical. It's rare because part of the hash calculation based on the "log.date" which changes every second).