feat(watch), introduce --import to fetch objects on .bitmap change #8795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful when using git.
It resolves the following issue - a user is running
git pullwhich updates the components and the .bitmap file. Because the objects locally are not updated, the .bitmap has new versions that don't exist in the local scope. As soon as the watcher gets an event about a file change, it loads the component which throwsComponentsPendingImporterror.To resolve this, the new
--importflag imports the new objects as soon as the .bitmap file changes. For performance reasons, we import only when: 1) the .bitmap file has version changes and 2) this new version is not already in the scope.