Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(insights), make the circular dependencies output clearer #8784

Merged
merged 1 commit into from
Apr 15, 2024
Merged

improvement(insights), make the circular dependencies output clearer #8784

merged 1 commit into from
Apr 15, 2024

Conversation

davidfirst
Copy link
Member

By doing the following two:

  • reverse the order of the components to start from the dependents to the dependencies
  • add the first item to the last to help understanding the circular.

For example, imagine the following circular: A1 -> B1 -> B2 -> A1 (read as A1 uses B1).

Before

Cyclic dependency
-----------------
- f46b89d0-remote/comp/[email protected]
- f46b89d0-remote/comp/[email protected]
- f46b89d0-remote/comp/[email protected]

Now

Cyclic dependency
-----------------
- f46b89d0-remote/comp/[email protected]
- f46b89d0-remote/comp/[email protected]
- f46b89d0-remote/comp/[email protected]
- f46b89d0-remote/comp/[email protected]

@davidfirst davidfirst merged commit 81211ee into master Apr 15, 2024
11 checks passed
@davidfirst davidfirst deleted the insights-reverse-circular-order branch April 15, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfirst @GiladShoham