Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve preview entries #8691

Merged
merged 9 commits into from
May 15, 2024
Merged

Conversation

Jinjiang
Copy link
Member

@Jinjiang Jinjiang commented Mar 20, 2024

Proposed Changes

  • create preview-modules-xxx.mjs and preview-run-xxx.mjs in @teambit/preview to include all the generated code imports (like the mounters, docs templates, and the preview pre-bundle). they are pure package code which Vite and our default webpack config can handle
  • leave only source code imports (xxx.docs.md, xxx.compositions.xx) in the preview entries

By doing that, Vite dev server doesn't need to optimize entries or add commonjs plugin anymore.

@GiladShoham GiladShoham merged commit 90228d3 into master May 15, 2024
11 checks passed
@GiladShoham GiladShoham deleted the jinjiang/preview-entries-improvement branch May 15, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants