Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude ui-bundle folder from .npmignore for core aspect #7364

Merged
merged 2 commits into from
May 5, 2023
Merged

fix: exclude ui-bundle folder from .npmignore for core aspect #7364

merged 2 commits into from
May 5, 2023

Conversation

leimonio
Copy link
Contributor

@leimonio leimonio commented May 5, 2023 •
edited
Loading

Proposed Changes

Exclude ui-bundle artifact folder in .npmignore for @teambit/ui

Before

.npmignore

dist/tsconfig.tsbuildinfo

/*.ts
artifacts/

After

.npmignore

dist/tsconfig.tsbuildinfo

/*.ts
artifacts/
!artifacts/ui-bundle

@leimonio leimonio changed the title fix: exclude ignored folder for core aspect fix: exclude ui-bundle folder from .npmignore for core aspect May 5, 2023
@leimonio leimonio changed the title fix: exclude ui-bundle folder from .npmignore for core aspect fix: exclude ui-bundle folder from .npmignore for core aspect May 5, 2023
GiladShoham
GiladShoham previously approved these changes May 5, 2023
View reviewed changes
@GiladShoham GiladShoham enabled auto-merge (squash) May 5, 2023 15:26
davidfirst
davidfirst previously approved these changes May 5, 2023
View reviewed changes
@leimonio leimonio dismissed stale reviews from davidfirst and GiladShoham via 5e16a7f May 5, 2023 15:44
@GiladShoham GiladShoham merged commit 710071a into master May 5, 2023
@GiladShoham GiladShoham deleted the fix/npm-ignore-core-aspect branch May 5, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfirst davidfirst davidfirst approved these changes

@GiladShoham GiladShoham GiladShoham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leimonio @davidfirst @GiladShoham