Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load aspects error handling #7286

Merged
merged 14 commits into from
Apr 19, 2023
Merged

load aspects error handling #7286

merged 14 commits into from
Apr 19, 2023

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Apr 19, 2023 •
edited
Loading

Proposed Changes

  • improve aspects loading errors
  • getting workspace name for different scope aspects funcs
  • remove pnpm output divider
  • remove your workspace is ready to use from the install output
  • change ensured capsule success message
  • improve LoadAspectsOptions type and expose it
  • add currentCommand name to cli onStartFn
  • add "addFailedToLoadExtension" API to envs aspect
  • add break line to output
  • add "inInstallContext" to workspace aspect

@GiladShoham GiladShoham merged commit a6e7ef8 into master Apr 19, 2023
@GiladShoham GiladShoham deleted the load-aspects-error-handling branch April 19, 2023 19:06
@GiladShoham GiladShoham mentioned this pull request Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guysaar223 guysaar223 guysaar223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiladShoham @guysaar223