Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes(Compare): Lane & Component Compare enhancements #7243

Merged
merged 10 commits into from
Apr 5, 2023
Merged

Conversation

luvkapur
Copy link
Member

@luvkapur luvkapur commented Apr 4, 2023

Proposed Changes

  • lanes.main.runtime
    • update diffStatus api to import missing heads from main
  • LaneSelector
    • add keyboard shortcuts - up, down arrows to scroll the list and enter to navigate
  • ComponentCompare
    • update CodeCompare- adjust to content height
  • LaneCompare
    • update API to allow managing state from outside
  • LaneComparePage
    • design refresh
    • use new LaneSelector

davidfirst
davidfirst previously approved these changes Apr 4, 2023
odedre
odedre previously approved these changes Apr 4, 2023
@luvkapur luvkapur requested a review from davidfirst April 5, 2023 14:12
@luvkapur luvkapur merged commit d314f3d into master Apr 5, 2023
@luvkapur luvkapur deleted the compare-updates branch April 5, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants