Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ws-config) - various fixes for ws-config write generated config files #7234

Merged
merged 1 commit into from
Apr 2, 2023
Merged

fix(ws-config) - various fixes for ws-config write generated config files #7234

merged 1 commit into from
Apr 2, 2023

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Apr 2, 2023 •
edited
Loading

Proposed Changes

  • add include to the generated global types folder from the generated tsconfig files
  • add node_modules/@types to the typeRoots in the generated root tsconfig file
  • reference relative config files with ./ at the beginning (some tools like TS don't know to use relative path correctly when not start with . or ..)

@GiladShoham GiladShoham enabled auto-merge (squash) April 2, 2023 12:35
@GiladShoham GiladShoham merged commit cfd48c7 into master Apr 2, 2023
@GiladShoham GiladShoham deleted the ws-config-write-fixes branch April 2, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guysaar223 guysaar223 guysaar223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiladShoham @guysaar223