fix(merge): avoid writing failed snap versions in .bitmap file #7185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, when tagging/snapping, we write the .bitmap to the filesystem only once the process was completed successfully. This way, if the build-process fails, it throws and exit the process without writing the versions to the .bitmap.
In case of merge, the snap process is wrapped inside try/catch block, so if it failed to run the pipeline, it still continues to the next step and eventually writes the .bitmap at the end of the process with the failed versions.
This PR fixes it by restoring the .bitmap content inside the
catchblock.