Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't crash on symlinked directories when hard linking all files of a dir #7182

Merged
merged 3 commits into from
Mar 22, 2023
Merged

fix: don't crash on symlinked directories when hard linking all files of a dir #7182

merged 3 commits into from
Mar 22, 2023

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Mar 21, 2023

Proposed Changes

  • When a hard linking all files from a directory, copy directory symlinks.

@zkochan zkochan marked this pull request as ready for review March 21, 2023 20:21
@zkochan zkochan enabled auto-merge (squash) March 21, 2023 20:52
@zkochan
Copy link
Member Author

zkochan commented Mar 21, 2023

The build failed on the new test. Not sure why. e2e passed but the build failed on the same test.

@GiladShoham GiladShoham merged commit 777bc53 into master Mar 22, 2023
@GiladShoham GiladShoham deleted the fix-link-dir branch March 22, 2023 19:25
@zkochan zkochan mentioned this pull request Apr 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkochan @GiladShoham