New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lane-change-scope), block when lane is exported, throw when scope-name is invalid #7139

Merged

davidfirst merged 1 commit into master from fix-lane-change-scope

Mar 10, 2023

Member

davidfirst commented Mar 10, 2023

Proposed Changes

block bit lane change-scope when the lane is not new, because then, whole history of the current lane needs to be exported, otherwise, on the next export, the remote will throw about missing objects. It's much easier to just create a new lane with the new scope-name.
in case the scope-name is invalid, throw an error about it. Currently, it lets you use an invalid scope-name and saves it in the lane-object incorrectly.


          fix(lane-change-scope), block when lane is exported, throw when scope…

0b4db3d

…-name is invalid

GiladShoham approved these changes

View reviewed changes

davidfirst merged commit d5e92f3 into master

davidfirst deleted the fix-lane-change-scope branch

March 10, 2023 19:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet