Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix, handle soft-remove on a new lane and import soft-removed components #7137

Merged
merged 2 commits into from
Mar 9, 2023
Merged

fix, handle soft-remove on a new lane and import soft-removed components #7137

merged 2 commits into from
Mar 9, 2023

Conversation

davidfirst
Copy link
Member

Proposed Changes

  • when a lane is new (not exported yet), don't allow soft-remove. suggest to "bit remove" instead. we already do the same when components are new.
  • fix obscure error "Cannot read properties of undefined (reading 'id') when importing locally soft-removed component.

@davidfirst davidfirst merged commit e16d859 into master Mar 9, 2023
@davidfirst davidfirst deleted the soft-remove-new-lane branch March 9, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfirst @GiladShoham