Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(envs) store envs data for env itself + load envs as aspect from scope #7124

Merged
merged 5 commits into from
Mar 6, 2023
Merged

fix(envs) store envs data for env itself + load envs as aspect from scope #7124

merged 5 commits into from
Mar 6, 2023

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Mar 6, 2023 •
edited
Loading

Proposed Changes

  • calc env descriptor for env itself
  • remove calc env descriptor from the workspace aspect, and use it from the envs aspect
  • load envs as aspects when loading from the scope

@GiladShoham GiladShoham changed the title envs self data envs self data + load as aspect from scope Mar 6, 2023
@GiladShoham GiladShoham changed the title envs self data + load as aspect from scope fix(envs) store envs data for env itself + load as aspect from scope Mar 6, 2023
@GiladShoham GiladShoham changed the title fix(envs) store envs data for env itself + load as aspect from scope fix(envs) store envs data for env itself + load envs as aspect from scope Mar 6, 2023
guysaar223
guysaar223 previously approved these changes Mar 6, 2023
View reviewed changes
@GiladShoham GiladShoham merged commit c91ca74 into master Mar 6, 2023
@GiladShoham GiladShoham deleted the envs-self-data branch March 6, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guysaar223 guysaar223 guysaar223 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiladShoham @guysaar223