Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, run the proper the pipeline for snap/tag in the new env #7040

Merged
merged 2 commits into from
Feb 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scopes/pipelines/builder/builder.service.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ export type BuilderServiceOptions = {
dev?: boolean;
};

type BuilderTransformationMap = ServiceTransformationMap & {
type BuilderTransformationMap = ServiceTransformationMap & {
getBuildPipe: () => BuildTask[];
getTagPipe: () => BuildTask[];
getSnapPipe: () => BuildTask[];
}
};

export type EnvsBuildContext = { [envId: string]: BuildContext };

Expand Down Expand Up @@ -155,16 +155,16 @@ export class BuilderService implements EnvService<BuildServiceResults, BuilderDe
},
getTagPipe: () => {
// TODO: refactor after defining for an env property
const pipeline = env.snap();
const pipeline = env.tag();
if (!pipeline || !pipeline.compute) return [];
return pipeline?.compute(envContext);
},
getSnapPipe: () => {
const pipeline = env.tag();
const pipeline = env.snap();
if (!pipeline || !pipeline.compute) return [];
return pipeline?.compute(envContext);
},
}
};
}

private renderOnePipe(pipeName, tasks) {
Expand Down