Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI fixes #6818

Merged
merged 42 commits into from
Jan 4, 2023
Merged

UI fixes #6818

merged 42 commits into from
Jan 4, 2023

Conversation

ranm8
Copy link
Member

@ranm8 ranm8 commented Dec 20, 2022 •
edited by GiladShoham
Loading

Proposed Changes

  • overview compositions
  • created composition-gallery and composition-card components
  • moved props table outside of iframe
  • fixed onload event timing on preview.tsx
  • added skeleton to readme

ranm8 and others added 30 commits December 19, 2022 20:55
@ranm8
line height in menu
1274e67
@ranm8
skip includes
0542437
@ranm8
Merge branch 'master' of github.com:teambit/bit into ui-fixes
dfe1d0e
@ranm8
skip right side
2cd4434
@ranm8
inner padding
e33ba1b
@ranm8
Merge branch 'master' of github.com:teambit/bit into ui-fixes
628dd3e
@ranm8
support skipIncldues
39c17f6
@ranm8
changes
edd01ad
@ranm8
Merge branch 'master' of github.com:teambit/bit into ui-fixes
90678ba
@ranm8
Merge branch 'master' of github.com:teambit/bit into ui-fixes
d6e3c29
@ranm8
fixes
f311f7e
@ranm8
comment out
ac3fb77
@ranm8
lane fixes
946ea01
@ranm8
padding
7c6a019
@odedre
composition carousel and gallery
66328fc
@odedre
composition panel styles
ec92da4
@odedre
lint
a199cfe
@ranm8
Merge branch 'master' of github.com:teambit/bit into ui-fixes
cb87fb1
@odedre
commented out compositions carousel in overview
5070f18
@odedre
Merge remote-tracking branch 'origin/ui-fixes' into composition-gallery
23a3077
@odedre
reverted composition panel changes
ca0d058
@odedre
renamed compositions -> preview
151dbf3
@odedre
composition card skeleton - initial design
16f9202
@odedre
composition gallery skeleton
394ce5c
@odedre
composition gallery in overview
ba75782
@odedre
styling composition card skeleton
f55b2bf
@odedre
lint fix
03f9ad8
@GiladShoham
Merge branch 'master' into ui-fixes
a940ef8
@odedre
skip includes false unless getting true from url
f3a857d
@odedre
preview - onload to run along with pubsub event
46228a4
GiladShoham
GiladShoham previously approved these changes Jan 3, 2023
View reviewed changes
@GiladShoham GiladShoham merged commit 5974b97 into master Jan 4, 2023
@GiladShoham GiladShoham deleted the ui-fixes branch January 4, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranm8 @GiladShoham @odedre