Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New envs api and env plugin #6693

Merged
merged 103 commits into from
Dec 1, 2022
Merged

New envs api and env plugin #6693

merged 103 commits into from
Dec 1, 2022

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Nov 22, 2022

Proposed Changes

  • new env plugin (.bit-env)
  • do not dedup dev server by peer dependencies in case rootComponents is enabled
  • new XXX-env-type interfaces
  • when compiling group of components, compile all envs first
  • compute dev files from env.jsonc file
  • all aspects to register DevPatternDescriptor which contain a name of the pattern - this name is used by env.jsonc as the key
  • add names to pattern registered by docs, composition and tester aspects
  • make worker.declareWorker sync op
  • calculate env policy from env.jsonc file
  • fix pnpm's publicHoistPattern to handle eslint plugins correctly
  • new ServiceHandlerContext class
  • new ServiceHandlerFactory interface
  • change ServiceHandler interface
  • get components templates from env (getGeneratorTemplates)
  • get starters templates from env (getGeneratorStarters)
  • new StarterList class
  • new TemplateList class
  • add --aspect flag to bit templates command, to filter templates in result
  • fallback to core templates if template not found in manually registered template
  • add aspectFilePath (*.aspect.ts|js) prop to AspectDefinition type
  • add OnAspectLoadErrorHandler to plugins class
  • try to re-load plugins that were failed to load after re-compile/install
  • new Pipeline class
  • new PackageGenerator class
  • write preview root file into dist folder of the component instead of the root of the component
  • move error boundaries outside of the composition app component
  • on preview root file, import directly from the aspect file (.aspect.ts|js) instead of the aspect root folder
  • only bundle host dependencies which directly declared like this (do not auto add any env's peers into the list)
  • remove @babel/runtime and core-js from deps of any component uses the react env (or envs that extends react)

ranm8 and others added 30 commits October 3, 2022 18:44
@@ -1,8 +1,14 @@
@import '~@teambit/ui-foundation.ui.constants.z-indexes/z-indexes.module.scss';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GiladShoham GiladShoham marked this pull request as ready for review December 1, 2022 15:39
@GiladShoham GiladShoham merged commit e0f85c8 into master Dec 1, 2022
@GiladShoham GiladShoham deleted the new-envs-api-env-plugin branch December 1, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants