Lanes: Create/Delete GQL #6656
Merged
Lanes: Create/Delete GQL #6656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfirst
reviewed
Nov 14, 2022
scopes/lanes/lanes/create-lane.ts
Outdated
| export async function createLaneInScope(laneName: string, scope: ScopeMain): Promise<Lane> { | ||
| const lanes = await scope.legacyScope.listLanes(); | ||
| if (lanes.find((lane) => lane.name === laneName)) { | ||
| throw new BitError(`lane "${laneName}" already exists, to switch to this lane, please use "bit switch" command`); |
There was a problem hiding this comment.
"bit switch" is probably not applicable when creating lane from scope..
davidfirst
reviewed
Nov 14, 2022
davidfirst
previously approved these changes
Nov 14, 2022
davidfirst
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
createLaneMutationdeleteLanesMutationLanesMainRuntimeto support creating lane from scopeLanesMainRuntimeto support deleting lanes from scope