Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react env minor #6526

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Fix react env minor #6526

merged 3 commits into from
Oct 18, 2022

Conversation

benjgil
Copy link
Contributor

@benjgil benjgil commented Oct 6, 2022

Proposed Changes

  • bit of incorrect syntax got it's way through to the react.env's createEsmCompilerTask
  • was an object[] instead of Function[]

@GiladShoham GiladShoham enabled auto-merge (squash) October 18, 2022 10:49
@GiladShoham GiladShoham merged commit 4c04dc4 into master Oct 18, 2022
@GiladShoham GiladShoham deleted the fix-react-env-minor branch October 18, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjgil @GiladShoham