fix(status), do not show the DeprecatedDependencies issue when undepr…

…ecated locally (#8882)
teambit · May 13, 2024 · 8bdaf5c · 8bdaf5c
1 parent 87c3aa9
commit 8bdaf5c
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/e2e/harmony/deprecate.e2e.1.ts b/e2e/harmony/deprecate.e2e.1.ts
@@ -211,5 +211,13 @@ describe('bit deprecate and undeprecate commands', function () {
     it('bit status should show the DeprecatedDependencies component-issue', () => {
       helper.command.expectStatusToHaveIssue(IssuesClasses.DeprecatedDependencies.name);
     });
+    describe('un-deprecating it', () => {
+      before(() => {
+        helper.command.undeprecateComponent('comp2');
+      });
+      it('bit status should not show the DeprecatedDependencies component-issue anymore', () => {
+        helper.command.expectStatusToNotHaveIssue(IssuesClasses.DeprecatedDependencies.name);
+      });
+    });
   });
 });
diff --git a/scopes/component/deprecation/deprecation.main.runtime.ts b/scopes/component/deprecation/deprecation.main.runtime.ts
@@ -129,6 +129,9 @@ export class DeprecationMain {
    */
   private async isDeprecatedByIdWithoutLoadingComponent(componentId: ComponentID): Promise<boolean> {
     if (!componentId.hasVersion()) return false;
+    const bitmapEntry = this.workspace.bitMap.getBitmapEntryIfExist(componentId);
+    if (bitmapEntry && bitmapEntry.isDeprecated()) return true;
+    if (bitmapEntry && bitmapEntry.isUndeprecated()) return false;
     const modelComp = await this.workspace.scope.getBitObjectModelComponent(componentId);
     if (!modelComp) return false;
     const isDeprecated = await modelComp.isDeprecated(

diff --git a/src/consumer/bit-map/component-map.ts b/src/consumer/bit-map/component-map.ts
@@ -317,6 +317,16 @@ export default class ComponentMap {
     if (!removeAspectConf) return false;
     return removeAspectConf !== '-' && removeAspectConf.removed === false;
   }
+  isDeprecated() {
+    const deprecationConf = this.config?.[Extensions.deprecation];
+    if (!deprecationConf) return false;
+    return deprecationConf !== '-' && deprecationConf.deprecate;
+  }
+  isUndeprecated() {
+    const deprecationConf = this.config?.[Extensions.deprecation];
+    if (!deprecationConf) return false;
+    return deprecationConf !== '-' && deprecationConf.deprecate === false;
+  }
 
   sort() {
     this.files = R.sortBy(R.prop('relativePath'), this.files);