Skip to content

Commit

Permalink
do not store env version in the envs data in model (#6511)
Browse files Browse the repository at this point in the history
  • Loading branch information
GiladShoham authored Oct 3, 2022
1 parent e4dd956 commit 04a55c4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion e2e/harmony/custom-env.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('custom env', function () {
it('should have the correct env in the envs aspect data after additional tag', () => {
const comp1 = helper.command.catComponent('comp1@latest');
const envIdFromModel = getEnvIdFromModel(comp1);
expect(envIdFromModel).to.equal(`${envId}@0.0.2`);
expect(envIdFromModel).to.equal(`${envId}`);
});
});
});
Expand Down
4 changes: 3 additions & 1 deletion scopes/workspace/workspace/workspace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,9 @@ export class Workspace implements ComponentFactory {

return {
type: systemDescriptor.type,
id: env.id,
// Make sure to store the env id in the data without the version
// The version should always come from the aspect id configured on the component
id: env.id.split('@')[0],
name: env.name,
icon,
description: env.description,
Expand Down

0 comments on commit 04a55c4

Please sign in to comment.