Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin chromedriver version to 114.0.5735.90 in test E2E CI job #493

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

SleepySquash
Copy link
Contributor

@SleepySquash SleepySquash commented Jul 26, 2023

Synopsis

nanasess/setup-chromedriver action throws 404:

##setup chromedriver
/home/runner/work/_actions/nanasess/setup-chromedriver/v1/lib/setup-chromedriver.sh  linux64
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0   1[9](https://github.com/team113/messenger/actions/runs/5667596598/job/15356626973?pr=476#step:9:10)3    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
Error: The process '/home/runner/work/_actions/nanasess/setup-chromedriver/v1/lib/setup-chromedriver.sh' failed with exit code 22

Solution

Since fixing the error requires some work from mainainers, as chromedriver 115+ uses a new download links, this PR just pins temporary the chromedriver version to the latest available in the old download link style: 114.0.5735.90.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::toolchain Changes of project toolchain labels Jul 26, 2023
@SleepySquash SleepySquash added this to the 0.1.0-alpha.10 milestone Jul 26, 2023
@SleepySquash SleepySquash self-assigned this Jul 26, 2023
@SleepySquash
Copy link
Contributor Author

SleepySquash commented Jul 26, 2023

FCM

Pin `chromedriver` version to `114.0.5735.90` in `test E2E` CI job (#493)

@SleepySquash SleepySquash marked this pull request as ready for review July 26, 2023 11:26
@SleepySquash SleepySquash requested a review from tyranron July 26, 2023 11:26
@SleepySquash SleepySquash merged commit b2d1502 into main Jul 26, 2023
@SleepySquash SleepySquash deleted the fix-chromedriver-action branch July 26, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::toolchain Changes of project toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants