Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/justiceotuya/adding redux #32

Merged
merged 10 commits into from
Jun 6, 2019
Merged

Feature/justiceotuya/adding redux #32

merged 10 commits into from
Jun 6, 2019

Conversation

justiceotuya
Copy link

No description provided.

justiceotuya
justiceotuya commented Jun 3, 2019
View reviewed changes
Copy link
Author

@justiceotuya justiceotuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Am sorry the changes reached up to 2000, its just a file name change that caused this. i had to change the file names for it to pass travis

olajohn-ajiboye
olajohn-ajiboye previously approved these changes Jun 5, 2019
View reviewed changes
Copy link

@olajohn-ajiboye olajohn-ajiboye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok other than the requested change. Nice job overall.

components/layout/components/PageLayout.test.jsx Show resolved Hide resolved
Way2nnadi
Way2nnadi approved these changes Jun 5, 2019
View reviewed changes
Copy link

@Way2nnadi Way2nnadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uimarshall uimarshall merged commit 72f93c8 into master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Way2nnadi Way2nnadi Way2nnadi approved these changes

@cimthog cimthog Awaiting requested review from cimthog

@EngrEric EngrEric Awaiting requested review from EngrEric

@enyeInc enyeInc Awaiting requested review from enyeInc

@uimarshall uimarshall Awaiting requested review from uimarshall

@olajohn-ajiboye olajohn-ajiboye Awaiting requested review from olajohn-ajiboye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justiceotuya @Way2nnadi @olajohn-ajiboye @uimarshall